-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Marji/improve naming for top mentions implementations #25133
Closed
marjisound
wants to merge
16
commits into
main
from
marji/improve-naming-for-top-mentions-implementations
Closed
WIP - Marji/improve naming for top mentions implementations #25133
marjisound
wants to merge
16
commits into
main
from
marji/improve-naming-for-top-mentions-implementations
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marjisound
changed the base branch from
jc/filter-capi-data-auto-filters
to
main
June 21, 2022 18:32
marjisound
changed the base branch from
main
to
jc/filter-capi-data-auto-filters
June 22, 2022 07:48
…ming-for-top-mentions-implementations
marjisound
changed the base branch from
jc/filter-capi-data-auto-filters
to
main
June 22, 2022 08:14
marjisound
changed the base branch from
main
to
jc/filter-capi-data-auto-filters
June 22, 2022 08:15
17 tasks
2 tasks
Closing this PR as we did some naming improvement in #25152 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Does this change need to be reproduced in dotcom-rendering ?
Screenshots
What is the value of this and can you measure success?
Checklist
Does this affect other platforms?
Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?
Does this change break ad-free?
Does this change update the version of CAPI we're using?
Accessibility test checklist
Tested